honojs / hono

Web framework built on Web Standards
https://hono.dev
MIT License
20.33k stars 582 forks source link

TODO #2

Closed yusukebe closed 2 years ago

yusukebe commented 2 years ago

Middleware

metrue commented 2 years ago

I really want to help on the "Logger" middleware task, would you describe a little more on it?

yusukebe commented 2 years ago

Hey @metrue

Thank you for your proposal, but API design for middleware is obscure. I'm still thinking about it. Please wait a moment!

metrue commented 2 years ago

Hi @yusukebe

I can help on the "Basic Auth" if you're not working on it now

yusukebe commented 2 years ago

Hi @metrue Thank you! I want you help on writing the "Basic Auth". But now, I'm rewriting the code to migrate from JavaScript to TypeScript (Yes, TypeScript!!) If you can, please wait a moment writing the code. If it is done, I will mention to you.

yusukebe commented 2 years ago

Hi @metrue Migrating to TypeScript is done! If you want, please write the code of Basic Auth middleware.

metrue commented 2 years ago

@yusukebe yeah, PR is on the way 👨🏻‍💻

And I think it'd be great we setup a lint script for the codes to enforce a consistent code style.

metrue commented 2 years ago

Hi @yusukebe

About how to test topic, could you share a little more about it? it's about document or it's about Hono's test-ability? or you already got some ideas? Maybe we can create another issue to track it?

yusukebe commented 2 years ago

@metrue It's not so important. I forgot meaning of the topic:( Please ignore.

metrue commented 2 years ago

For the middleware 'X-Response-Time', the logger middleware already included the response time information. https://github.com/yusukebe/hono/blob/master/src/middleware/logger/logger.ts#L70

yusukebe commented 2 years ago

@metrue Yes. I think it's not necessary. We don't need to implement it.

yusukebe commented 2 years ago

Almost done!! To be continue ... => #68