Support JSR - Githubissues

honojs / hono

Web framework built on Web Standards

https://hono.dev

MIT License

17.16k stars 484 forks source link

Support JSR #2201

Closed yusukebe closed 1 month ago

yusukebe commented 5 months ago

What is the feature you are proposing?

A new package repository:

https://jsr.io/

I've already got the namespace:

alexgleason commented 4 months ago

It looks like @Kyiro has started this: https://jsr.io/@kyiro/hono/0.1.1/deno.json

How did he do it?

Kyiro commented 4 months ago

I described what I did in the discord server but I'll post it here as well:

JSR doesn't support global/module type augmentations (yet) so ContextVariableMap can't be augmented and JSX support had to be removed completely
Uses "slow types"
Publishes from the deno_dist folder instead of src (doesn't really matter except for the fact I forgot to add other adapter code in)

I was pretty much just experimenting, so that's why it's published as version 0.1.1.

yusukebe commented 4 months ago

Thanks @Kyiro

I too would like to make Hono support JSR, but I haven't started working on it yet. Even if we could, I think we would have to figure out the release flow.

ericlery commented 2 months ago

Any news on this?

alexgleason commented 2 months ago

@ericlery I was just wondering the same thing.

I spent 20 minutes looking at Oak instead. And while I respect it, I concluded that hono is still the best.

Then I added this to my deno.json and pretended it's on JSR:

{
  "imports": {
    "hono": "https://deno.land/x/hono@v4.3.1/mod.ts"
  }
}

yusukebe commented 2 months ago

I'll be working on it for the next minor release.

nakasyou commented 2 months ago

I think that deno_dist will be unnecessary in the future if hono jsr package loads from src. If you do that, we need to add publish command allowing sloppy-imports flag.

yusukebe commented 2 months ago

I have some ideas. Wait a minute.

nakasyou commented 1 month ago

I have seen people who doesn't know that deno.land/x has been deprecated. As a solution, what do you think about share to Hono users? For example, using X is most efficient way. Also publishing new version to deno.land/x with warning message on README is better way.

yusukebe commented 1 month ago

@nakasyou

You are right! I'll work on it. Thank you!

yusukebe commented 1 month ago

@nakasyou

I've added the description for it on the migration guide and the readme: https://github.com/honojs/hono/pull/2879

Plus, announced it on X.

Thanks for your suggestion!

yusukebe commented 1 month ago

Hey! This was really completed by #2662. Closing!