honojs / hono

Web framework built on Web Standards
https://hono.dev
MIT License
20.38k stars 584 forks source link

chore(test): merge deno runtime coverage #3456

Closed usualoma closed 1 week ago

usualoma commented 1 month ago

Checking the results in github actions...

The author should do the following, if applicable

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.52%. Comparing base (0a18c02) to head (8d3a0b7).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3456 +/- ## ========================================== + Coverage 89.80% 90.52% +0.72% ========================================== Files 159 159 Lines 10120 10179 +59 Branches 2793 2954 +161 ========================================== + Hits 9088 9215 +127 + Misses 1032 962 -70 - Partials 0 2 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

usualoma commented 1 month ago

On Codecov, the coverage results for "coverage/deno-runtime-coverage.lcov" overwrite the results for main, resulting in a lower coverage rate. It would be nice if the results could be merged.

usualoma commented 1 month ago

When generating lcov format data from deno coverage, some comment lines are incorrectly treated as executable lines, resulting in unnecessary uncovered.

CleanShot 2024-09-28 at 13 48 42@2x

CleanShot 2024-09-28 at 13 51 33@2x

usualoma commented 1 month ago

I have created a pull request to fix this issue in deno. Whether or not it is merged is up to deno.

https://github.com/denoland/deno/pull/25939

yusukebe commented 1 month ago

@usualoma Thanks!

exoego commented 1 week ago

@usualoma Deno v2.0.5 includes the change you contributed in https://github.com/denoland/deno/pull/25939

usualoma commented 1 week ago

@exoego Thanks for telling me.

usualoma commented 1 week ago

I would like to continue with #3632, where the changes made by the pull request are easy to understand.