honojs / hono

Web framework built on Web Standards
https://hono.dev
MIT License
20.53k stars 595 forks source link

ci: compare bundle size #3661

Closed EdamAme-x closed 1 week ago

EdamAme-x commented 1 week ago

The author should do the following, if applicable

EdamAme-x commented 1 week ago

if this pr is merged, before.js will also be output to show the change in bundle size.

image

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (7e17b76) to head (3aef3ae). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3661 +/- ## ======================================= Coverage 91.69% 91.70% ======================================= Files 159 159 Lines 10138 10145 +7 Branches 2976 2908 -68 ======================================= + Hits 9296 9303 +7 Misses 840 840 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

EdamAme-x commented 1 week ago

Hi @m-shaka, could you please check this?

yusukebe commented 1 week ago

Hi @k2tzumi! Can you review this, you too?

EdamAme-x commented 1 week ago

what happen, DDoS...? image

EdamAme-x commented 1 week ago

hi @yusukebe, this pr should be ready.

EdamAme-x commented 1 week ago

It would be nicer if you could see a unit(like KB or MB) of bundle size, but it's OK to add it later

Agreed!
We will add custom metrics later, so it seems like a good idea to add them at that time.

yusukebe commented 1 week ago

@EdamAme-x @k2tzumi @m-shaka

Thank you all! Let's go with this.