honojs / hono

Web framework built on Web Standards
https://hono.dev
MIT License
20.53k stars 595 forks source link

feat(helper/factory): Calculate Context<Env> Type in createHandlers #3670

Closed sushichan044 closed 1 week ago

sushichan044 commented 1 week ago

closes #3467

This PR fixes a problem in createHandlers where the expected type information was not passed to subsequent handlers when middlewares changed the Context type.

The author should do the following, if applicable

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.70%. Comparing base (082862b) to head (087c5df). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #3670 +/- ## ======================================= Coverage 91.70% 91.70% ======================================= Files 159 159 Lines 10145 10145 Branches 2851 2857 +6 ======================================= Hits 9303 9303 Misses 840 840 Partials 2 2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

yusukebe commented 1 week ago

@sushichan044

Awesome! Thank you for your first contribution. Merging now.

mecab commented 1 week ago

I raised #3467 and I'm so happy to hear it is fixed. It is super helpful. I will try it soon.

Thank you @sushichan044 and @yusukebe !

Rykuno commented 1 week ago

I brought this issue up in the discord. Thank you!