SSE fetch gets cancelled => Hono Node server prints an error on console

ukstv commented 4 months ago

Disposition:

There is a Hono server, with a POST endpoint replying with Server-Sent Events
The response is consumed through fetch().response.body.getReader() Reader
Either (a) the reader cancels via reader.cancel(),
Or (b) fetch AbortSignal gets aborted

Expectation: things are working well Reality:

Node.js reports an error: TypeError: Response body object should not be disturbed or locked :(
You can not catch the error :(( It is just on console

The reproduction repository is on https://github.com/ukstv/hono-sse-repro

The error is from Readable.toWeb(incoming) line. It fails because incoming is "disturbed". That is kind of expected though, as the request got aborted.

yusukebe commented 3 months ago

Hi @ukstv

Sorry for the late reply. This maybe fixed the latest version. Can you try it?

ukstv commented 2 months ago

@yusukebe It works! Thank you!

honojs / node-server

SSE fetch gets cancelled => Hono Node server prints an error on console #179