honojs / vite-plugins

Vite Plugins for Hono
https://hono.dev
123 stars 34 forks source link

wrangler & miniflare dependencies as optional peerDependencies #164

Closed arisris closed 1 month ago

arisris commented 1 month ago

This is my first PR. I want join to the honojs community.

Since dev-server is not required to use cloudflare adapter, as it so i try to move miniflare dependencies into devDependencies and add them into optional peerDependencies including wrangler.

also i try to add bun & node adapter.

Thankyou

changeset-bot[bot] commented 1 month ago

⚠️ No Changeset found

Latest commit: 8f65bafc3cef4d537941d598df370d6936bc8f5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

yusukebe commented 1 month ago

Hi @arisris !

Thank you for your first PR! I want to review it, but can you separate this PR to the 3 PRs?

  1. Removing miniflare deps.
  2. Bun adapter.
  3. Node.js adapter.
arisris commented 1 month ago

@yusukebe Thanks. I will do it tomorow. After done i will close this PR

arisris commented 1 month ago

I have separate this with 3 PRs https://github.com/honojs/vite-plugins/pull/165 https://github.com/honojs/vite-plugins/pull/166 https://github.com/honojs/vite-plugins/pull/167

yusukebe commented 1 month ago

@arisris

Thanks! I'll see them later.