fix(dev-server): Move miniflare,wrangler to dev as it peer optional

honojs / vite-plugins

Vite Plugins for Hono

https://hono.dev

132 stars 34 forks source link

fix(dev-server): Move miniflare,wrangler to dev as it peer optional #165

Closed arisris closed 2 months ago

arisris commented 3 months ago

Since dev-server is not required to use cloudflare adapter, as it so i try to move miniflare dependencies into devDependencies and add them into optional peerDependencies including wrangler.

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: c48d3f4dd6a2a5fdd35a812e863cff4ba40cea79

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

| Name | Type | | --------------------- | ----- | | @hono/vite-dev-server | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

yusukebe commented 3 months ago

Hi @arisris

Looks good! I'd like you to do two things:

Add a description about installing miniflare and wrangler for the Cloudflare Adapter on the README.md.
Run yarn changeset on the top of the project to generate a changeset file. This is a patch change. And push it.

arisris commented 3 months ago

@yusukebe Sure, do i have to create new PRs again like before?

yusukebe commented 3 months ago

Hi @arisris

Sure, do i have to create new PRs again like before?

No! Please update this PR.

yusukebe commented 2 months ago

Hey @arisris !

Thank you for handling it. I've done the other remaining things. It looks good! Let's go with it.