honojs / vite-plugins

Vite Plugins for Hono
https://hono.dev
134 stars 35 forks source link

Added JSDoc default values to the Cloudflare Pages plugin options #81

Closed TheOnlyTails closed 9 months ago

TheOnlyTails commented 9 months ago

We are using this plugin over at @lipu-linku, and we recently ran into a problem where the entry defaults screwed us over, since we are building a regular REST API, and not a React client side app.

This PR adds very simple JSDoc to the options, to allow users to see their default values in their editor, instead of having to look them up in a subfolder of a monorepo.

changeset-bot[bot] commented 9 months ago

⚠️ No Changeset found

Latest commit: 7ceb55f541b918bc8fad22c2ae655c1da1425c8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

yusukebe commented 9 months ago

Hi @TheOnlyTails

Thanks! This is a good improvement. I'll merge it now.