search

honojs / website

Repository for hono.dev
https://hono.dev
68 stars 217 forks source link

Broken link for "Building a larger application" in RPC guide #237

Closed rexfordessilfie closed 4 months ago

rexfordessilfie commented 4 months ago

Problem

The link for "Building a larger application" in the RPC section of the docs should point to the "Building a larger application" section on the "Best Practices" page, but points to a section/fragment on the "RPC" guide that does not exist!

Relevant Link: https://hono.dev/guides/rpc#using-with-larger-applications

Screenshot

Screenshot 2024-02-10 at 16 16 13

Solution

I think this can be fixed by updating the link in the docs here to point to /guides/best-practices#building-a-larger-application.

Happy to make this quick fix or let someone else handle! Thanks for the awesome docs!

yusukebe commented 4 months ago

Hi @rexfordessilfie

It should be fixed, and the solution is good! Could you create a PR?

rexfordessilfie commented 4 months ago

Hi @rexfordessilfie

It should be fixed, and the solution is good! Could you create a PR?

Definitely @yusukebe! PR coming right up!

rexfordessilfie commented 4 months ago

PR opened here, @yusukebe: https://github.com/honojs/website/pull/238 👍