search

honojs / website

Repository for hono.dev
https://hono.dev
68 stars 209 forks source link

feat: Make natural path structure #357

Closed goisaki closed 2 weeks ago

goisaki commented 1 month ago

changes

goisaki commented 1 month ago

@yusukebe, Could you create the next branch for this and related future PRs?

yusukebe commented 1 month ago

@goisaki

Okay, just a moment!

goisaki commented 1 month ago

@yusukebe Resolved conflict to main branch! I'm waiting for the next branch.

yusukebe commented 1 month ago

Hi @goisaki

Sorry for the late. I'm considering the documentation for the Hono recently.

I'd like to discuss API documents before merging this PR. I noticed that the documentation generated by TSDoc/JSDoc would be good enough for the API (only API). So, I think if we have the docs by TSDoc/JSDoc, we don't need the API section for the doc. How do you think about it? Anyway, we have to discuss it elsewhere.

goisaki commented 1 month ago

Hi @yusukebe I see. Let's continue with the discussion. p.s. Please create the discussion since I am not the proposer.

goisaki commented 1 month ago

ref: https://github.com/orgs/honojs/discussions/2854

yusukebe commented 3 weeks ago

Hey @goisaki

Let's restart to work on this matter. I've created the next branch. Can you resolve the conflicts? Then, I'll merge this into the next and will work on other ideas that I'm thinking of now.

goisaki commented 3 weeks ago

Hi @yusukebe Thanks. Conflict resolved. In this PR, a Layout (by vitepress) wrap has been added to inject the redirect settings. This wrap includes the existing .vitepress/theme/NotFound.vue for compatibility, which now looks identical to the default theme in vitepress. I would like to remove this for code cleanliness, is that ok?

yusukebe commented 3 weeks ago

Thanks @goisaki !

Regarding redirecting, it's better to use Cloudflare Pages's redirect feature, which returns a Response with a 301 code.

https://developers.cloudflare.com/pages/configuration/redirects/

NicoPlyley commented 3 weeks ago

it's better to use Cloudflare Pages's redirect feature

@yusukebe Can you confirm it is working properly. I have tired to use it a few times, it says they were loaded in but it did not work. It's been about 1 year since I've last tired. I've resulting in just using page rules or bulk redirects instead

yusukebe commented 2 weeks ago

Sorry, I accidentally closed it. Reopened.

yusukebe commented 2 weeks ago

@NicoPlyley @goisaki

_redirects works well!

goisaki commented 2 weeks ago

Hi @yusukebe @NicoPlyley I made the change in https://github.com/honojs/website/commit/c71f9cb191b5b7d789804ba2542878cf3f45a100. Currently this PR includes the deletion of .vitepress/theme/NotFound.vue, is there any problem?

yusukebe commented 2 weeks ago

@goisaki Thanks

Currently this PR includes the deletion of .vitepress/theme/NotFound.vue, is there any problem?

I think we don't need to remove it. Do you have any reason to delete it?

goisaki commented 2 weeks ago

hi @yusukebe The display looks exactly the same as the default NotFound page. So I saw no positive reason to keep this file. Is there an intent to keep it?

yusukebe commented 2 weeks ago

The display looks exactly the same as the default NotFound page. So I saw no positive reason to keep this file. Is there an intent to keep it?

Ahh, deleting is okay. It was necessary for the old version of VitePress. Thanks!

goisaki commented 2 weeks ago

Thanks for agreeing. Ready to go!

yusukebe commented 2 weeks ago

@goisaki

Thanks! I'll merge this now into the next.