Closed imran1khan closed 1 week ago
@yusukebe Do you mind if I do a code review here? I have a few recommendations and updates.
@NicoPlyley bro feel free to add your ideas, it would be a great helpand learning
@NicoPlyley hi bro, please check out the new update that i made, bro i am seriously sorry for making so much mistake but thanks so much for your greate help,
and if i made some mistake again then feel free to currect me.
thanks so much.
one question i had was, why we have to make another .dev.vars
file because when we run prisma init
it's going to create .env
file so, do we have to delete that .env
file after coping the content into the .dev.vars
? because i thought prisma in not going to run without .env
file
@imran1khan First off you did a great job. Most the updates were just to add a bit of simplicity. I am unsure about the .env file with prisma so if the cli needs it then go ahead a leave that in. You might want to specify that in there too.
@NicoPlyley bro, thanks for your suggestion, i have added the .env
and explained it too. i know your time is precious, but let me know if you want some outher correction. and also i have squash the commits so,i thought it's good to let you know
Sorry for the late reply.
@yusukebe Do you mind if I do a code review here?
Yeah!
Hey @imran1khan !
This is great! I've left some comments. Please check them.
@imran1khan I added three things. I checked over it a few times I think it should be good after that. Yusuke will check again as well.
Thanks for continuing and update this and contributing!
@NicoPlyley , thnaks bro for taking your time and helping me, i am new to this, and i am very glad that you are so patience with me. so thanks alot. and let me know for some new addition
Hey @imran1khan
Please check my comment!
@yusukebe, bro i have added the main working file as index.ts
and the function file from which i am importing the function as prismaFunction.ts
, i hope it works. but let me know your suggestion
@imran1khan
Gooood! Thank you for your contribution!
@NicoPlyley also thank you for reviewing.
Let's go with it 🎉
@yusukebe thanks bro, i really appreciate your work and your help
issue #384 bro, if you need any help feel free to contact, i have made the nessery changes, hopefully you are going to like it
i have added a doc for prisma installation, i hope it's going to be helpfull for someone who want's to know how to install prisma in cloudflare workers, if you like my work feel free to contact me,
i have added docs related to how we can use prisma accelerate but i have not added any doc, on how we can use prisma using Database driver, because it's very easy to do and anyone can read the doc link that i have provied and understand this