search

honojs / website

Repository for hono.dev
https://hono.dev
68 stars 208 forks source link

ci: setup ci workflow #411

Closed Jayllyz closed 1 week ago

Jayllyz commented 1 week ago

Created a CI workflow to check Prettier format and run build.

yusukebe commented 1 week ago

Hi @Jayllyz

Checking formatting is very good. But honestly, I think this CI is not necessary in my opinion. If some user fix the typo and create a PR which is not formatted. Then, the CI will fail, but if the user does not notice it, I will have to ask the user to fix the format to pass the CI. It's a burden for me. So, it will be good I or some bot fix it not related PRs.

Jayllyz commented 1 week ago

No problem, I understand, thank you for your time and review.

yusukebe commented 1 week ago

@Jayllyz

Thank you for understanding! I'll close this PR now.