search

honoki / bbrf-client

The Bug Bounty Reconnaissance Framework (BBRF) can help you coordinate your reconnaissance workflows across multiple devices
MIT License
613 stars 90 forks source link

[issue] adding domains fail due to colon #60

Closed pdelteil closed 3 years ago

pdelteil commented 3 years ago

I was adding some domains and I had this error:

[ERROR] too many values to unpack (expected 2)

I discovered it was because of a IPv6 (therefore the : symbol)

Doing this solved the issue:

cat domains.txt | grep -v ":" | bbrf domain add - -s subfinder --show-new

honoki commented 3 years ago

Ah yes, BBRF doesn't currently support any ipv6 formats, so I guess this is expected to go wrong.

The error stems from trying to parse the input as <domain>:<ip> which is a supported format.

I will try and see if this can be resolved in a less blocking way, e.g. by ignoring malformed input rather than trying to parse it.

pdelteil commented 3 years ago

Ah yes, BBRF doesn't currently support any ipv6 formats, so I guess this is expected to go wrong.

The error stems from trying to parse the input as <domain>:<ip> which is a supported format.

I will try and see if this can be resolved in a less blocking way, e.g. by ignoring malformed input rather than trying to parse it.

Yes, I wasn't clear that wasn't my intention to add an ipv6, just got it from subfinder/assetfinder and crashed the adding process.

Like I said, is simple to fix adding a grep rule to filter them out, but I think that if you running an automated process of adding documents you wouldn't notice it that easy if you already have documents on that program.

Thank you!

Sh1Yo commented 2 years ago

Hi, I think the same thing should be implemented for bbrf domain update as well. For now ipv6 works fine in bbrf domain add only. UPD looks like both are not working now on 1.3.0 with ipv6. The only difference is that bbrf domain add doesn't give any errors