TLD's cannot be added in the outscope

Hi @honoki

I was using your application and I noticed that I could not add TLD's in the programs outscope.

For example, when I try to run this command:

bbrf outscope add *.gov www.federalreserve.gov -p FederalReserve

and then I do a:

bbrf show FederalReserve

The program returns me the following:

{"outscope":["www.federalreserve.gov"]}

It does not take into account the *.gov in the outscope, and I consider this a major bug for the application logic.

The particular bug is in the add_outscope function. As you can see its condition is made in such a way that it does not support the TLDs.

This is the condition I am referring to:

 if REGEX_DOMAIN.match(e) or e.startswith('*.') and REGEX_DOMAIN.match(e[2:]):
     changed = True
     outscope.append(e)

I took the audacity to do a local test of your implementation, and it confirms the problem that exists in the application:

>>> REGEX_DOMAIN = re.compile('^(?:[a-z0-9_](?:[a-z0-9-_]{0,61}[a-z0-9])?\\.)+[a-z0-9][a-z0-9-]{0,61}[a-z0-9]$')
>>> domain = "*.gov"
>>> print(REGEX_DOMAIN.match(domain[2:]))
None
>>> print(REGEX_DOMAIN.match(domain))
None
>>> print(REGEX_DOMAIN.match("hello.com"))
<re.Match object; span=(0, 8), match='hello.com'>
>>> print(REGEX_DOMAIN.match("*.hello.com"))
None
>>> print(REGEX_DOMAIN.match(".gov"))
None
>>> print(REGEX_DOMAIN.match("gov"))
None
>>> print(REGEX_DOMAIN.match("www.federalreserve.gov"))
<re.Match object; span=(0, 22), match='www.federalreserve.gov'>

As I said at the beginning, when I enter *.gov and www.federalreserve.gov in the outscope, only www.federalreserve.gov is added as you could see in the local experiment I did:

# So this one is added
>>> print(REGEX_DOMAIN.match("www.federalreserve.gov"))
<re.Match object; span=(0, 22), match='www.federalreserve.gov'>

# So this one is NOT added
>>> domain = "*.gov"
>>> print(REGEX_DOMAIN.match(domain[2:]))
None

I look forward to your reply, best regards.

honoki / bbrf-client

TLD's cannot be added in the outscope #73