honzabrecka / karma-reporter

A plugin for running clojurescript tests with Karma.
MIT License
24 stars 8 forks source link

Possibly make karma reporter derive from default reporter #11

Closed bhb closed 7 years ago

bhb commented 7 years ago

Currently, if another project uses a custom report type, by default it will not be printed when using karma. This caused me confusion when using test.chuck - see https://github.com/gfredericks/test.chuck/issues/52.

I understand that for karma, we don't want to print some report types, namely the :cljs.test/summary type that is (presumably intentionally) not implemented in karma-reporter. However, what do you think about making a blank implementation for that report type e.g.

(defmethod cljs.test/report [::karma :summary] [_]
  ;; do nothing 
)

and then have the karma reporter derive from the default:

(derive :jx.reporter.karma/karma :cljs.test/default)

I believe that would:

What do you think?

honzabrecka commented 7 years ago

I understand your issue and agree that it's something we should support. Would you mind open PR?