Added: sending money (API import method).

honzajavorek / fiobank

Fio Bank API in Python

ISC License

38 stars 21 forks source link

Added: sending money (API import method). #10

Closed im-n1 closed 5 months ago

im-n1 commented 8 years ago

Hey, hi, hello,

I've incorporated your library to my project and it works flawlessly, so big thank you.

However I've needed to add ability of sending money (Fio import method) so I did so.

New method send (because import is keyword)
Updated readme with an example.
Added new dependency xmltodict
Bumped to 0.1 because I've used the lib for a quite time and haven't found any bugs.

Please let me know you thoughts ;)

Cia on pyvo :)

honzajavorek commented 8 years ago

Hi, thank you very much for the contribution, it's awesome! This is still in my queue, but I promise I'll get to review this. I definitely want this feature in and I think not only me!

im-n1 commented 8 years ago

Cool,

let me know when you are ready then.

Cheers.

honzajavorek commented 8 years ago

If I understand correctly, this should implement #1, right?

im-n1 commented 8 years ago

Yes

honzajavorek commented 8 years ago

@grafa So after some time I'm getting back to maintaining this library and I'd like to incorporate your changes. However, a lot of things have changed since. If you feel like you would like to get back to this, please

rebase the PR on top of current master
format your commits according to conventional changelog so semantic releasing can correctly detect changes (recent commits in master can be your guide)
please try to add tests (existing tests can be your guide)

im-n1 commented 8 years ago

Hi there,

unfortunately I'm to busy to help you with this task. Feel free to dive into that.

Thanks.

honzajavorek commented 5 months ago

I didn't manage to get this done and there hasn't been a big ask for this feature. I'm sorry this didn't work out! Thanks for your work anyway, it's still appreciated 🙏 I'll close this and anyone feeling like following up is free to comment.