search

honzakral / django-threadedcomments

django-threadedcomments is a simple yet flexible threaded commenting system for Django.
BSD 3-Clause "New" or "Revised" License
623 stars 164 forks source link

Cleanup, example and overall improvements to django-threadedcomments #39

Closed vdboor closed 11 years ago

vdboor commented 12 years ago

Hi,

I've been looking into getting django-threadedcomments up to date, with clean examples. I hope you accept this first series of changes. It contains:

These were all parts I missed in the application, and I hope it saves other peoples time too. Thanks for your time to include these changes.

Diederik

honzakral commented 12 years ago

wow, thanks a lot! I have planned on doing a tiny sprint on threadedcomments this Tuesday so this is absolutely perfect.

I will add a few comment on the code on what I spot, but overall it looks very good.

Thanks!

vdboor commented 12 years ago

...great to know the timing was that good, and the work in appreciated :-) Looking forward to any other suggestions, and I'm curious what sprint you have planned. :-)

honzakral commented 12 years ago

well, we are having a little django sprint here in Prague, but since tickets have been piling up here I thought I would invest some effort into cleaning things up, your work is a great help.

kvbik commented 12 years ago

hey, thx for this huge amount of work. it looks like you invested a lot of time into this project.

i am willing to merge this stuff soon, but right now, i will test it in our production. if this integration test pass, lets make it a release, ok?

before that i have to check what version actually is on pypi..

can i have one {prosbu} for you? next time you want us to pull something, just split it to more pull requests - i understand we are way behing with new stuff - but it is way easier to check and commit smaller changes.

thx again, looking forward for more cleanup and features from you ;))

vdboor commented 12 years ago

Seems like a good plan, especially the testing and making a release as well. :-)

I'll keep my pull requests smaller next time. This was indeed a massive sprint to get things into shape, I don't think such big change is needed in the future.

If you have any specific feature plans in mind, please add them to the README. It's always nice to know where a project is heading to, and I'll keep the invitation in mind ;-)

vdboor commented 12 years ago

Hi, did you find time to merge the pull request back in? I was hoping to see a release on pypi :-)

kvbik commented 12 years ago

hey @vdboor - sorry, i didn't have anymore time. but we actually had another small sprint on tuesday. we finally have access to pypi, so right now, we will release current version there and your changes will follow asap.

vdboor commented 12 years ago

hi @kvbik, thanks for the follow up! This is great news to hear!

honzakral commented 11 years ago

sorry guys, I don't use MySQL so I haven't had a chance to test it properly, I will get right on it.

johanneswilm commented 11 years ago

@HonzaKral: ok, very cool!

honzakral commented 11 years ago

This is merged, Thanks a lot and sorry for the delay