search

honzakral / django-threadedcomments

django-threadedcomments is a simple yet flexible threaded commenting system for Django.
BSD 3-Clause "New" or "Revised" License
622 stars 165 forks source link

RemovedInDjango19Warning #71

Closed jimlyndon closed 7 years ago

jimlyndon commented 8 years ago

On the latest commit (f5094aa2bf8b656154f08e603c09c873dc22eb79), I'm seeing a lot of these:

RemovedInDjango19Warning: Model class django_comments.models.Comment doesn't declare an explicit app_label and either isn't in an application in INSTALLED_APPS or else was imported before its application was loaded. This will no longer be supported in Django 1.9.

Anyone else already experiencing or already reported this? I'll dig in but didn't want to dup work. Thanks!

vdboor commented 8 years ago

I noticed this too, but I'm not sure yet where to fix. Is this really an issue with threadecommends, or with https://github.com/django/django-contrib-comments? I noticed this fix here, which is not yet released: https://github.com/django/django-contrib-comments/commit/45347d0ae86f7e025197597f41e6d8d078ac8f2d

jimlyndon commented 8 years ago

I believe you are correct. I've specified a recent threaded comment as it points to the latest django comments release, where the problem seems to have been resolved.

On Thu, Oct 1, 2015 at 3:26 AM, Diederik van der Boor < notifications@github.com> wrote:

I noticed this too, but I'm not sure yet where to fix. Is this really an issue with threadecommends, or with https://github.com/django/django-contrib-comments? I noticed this fix here, which is not yet released: django/django-contrib-comments@45347d0 https://github.com/django/django-contrib-comments/commit/45347d0ae86f7e025197597f41e6d8d078ac8f2d

— Reply to this email directly or view it on GitHub https://github.com/HonzaKral/django-threadedcomments/issues/71#issuecomment-144688515 .