search

honzakral / django-threadedcomments

django-threadedcomments is a simple yet flexible threaded commenting system for Django.
BSD 3-Clause "New" or "Revised" License
622 stars 165 forks source link

Incompatible to Django 2.0 #93

Closed larsrinn closed 6 years ago

larsrinn commented 6 years ago

In Django 2.0 foreign key relations must have the parameter on_delete set: https://docs.djangoproject.com/en/2.0/releases/2.0/#features-removed-in-2-0 This is not the case for the parent field of the ThreadedComment model. To reflect the behaviour in Django 1.11, it would have to set to models.CASCADE

vdboor commented 6 years ago

Thanks! this is now merged.