Open yoke88 opened 3 years ago
Thank you again for contributing! What bug will this fix? Can you describe a typical case, where things go wrong? What format is expected and what format is delivered?
Regarding the "open in new window" it is best practice to let the user decide. With target="_blank"
the user has no choice.
nmap sometime can not get the app version。
for example
the required cpe_version must be format like this:
cpe:/a:microsoft:windows:2008
but if we miss the version info
the cpe_version can be cpe:/a:microsoft:windows
and the static generated cpe link is wrong, because cpe_version must match the pattern.
so we need dynaymic format the cpe_version
cpe:/a:microsoft:windows should be formatted to cpe:/a:microsoft:windows::
the empty app version is replaced with ::
Get Outlook for Androidhttps://aka.ms/AAb9ysg
Get Outlook for Androidhttps://aka.ms/AAb9ysg
From: Andreas Hontzia @.> Sent: Wednesday, May 26, 2021 2:20:21 PM To: honze-net/nmap-bootstrap-xsl @.> Cc: yoke88 @.>; Author @.> Subject: Re: [honze-net/nmap-bootstrap-xsl] fix CPE link (#18)
Thank you again for contributing! What bug will this fix? Can you describe a typical case, where things go wrong? What format is expected and what format is delivered?
Regarding the "open in new window" it is best practice to let the user decide. With target="_blank" the user has no choice.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/honze-net/nmap-bootstrap-xsl/pull/18#issuecomment-848495712, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAYAD4WCYI7JRE3QYO5WLO3TPSHKLANCNFSM45N7VZ3A.
This is definitely something, what nmap should fix. I will have a look, where I can address this upstream. Nevertheless I understand the point, thank you for explaining. The solution in JavaScript works, but I will check, if I can rewrite the CPE with XSLT to render it correctly in the first place.
Alternatively I could look for a different service to link to, but I doubt that this will give good results.
open CPE link in new window and fix CPE link if cpe version do not match the required format