search

hoodie / icalendar-rs

📆 icalendar library, in Rust of course - for fun
Apache License 2.0
126 stars 34 forks source link

No way to create VALARM, or add a component to a VEVENT #48

Closed tchernobog closed 1 year ago

tchernobog commented 2 years ago

I am looking for a way to add an alarm component to an Event, even by creating a component by hand (which I was able to do through the parser interface) and adding it to the Event.

Is there any support planned for VEVENTs?

hoodie commented 2 years ago

I don't see a reason not to add it actually

beyarkay commented 2 years ago

Just chipping in to say that this would be really useful, and the lack of this might make me have to move to a different calendar creator. Is it a hard task to add the functionality? (I'd be happy to add it and submit the PR)

mre commented 2 years ago

I'd also be interested in that for zerocal. 👍

beyarkay commented 2 years ago

@hoodie Any chance you could give a high level summary of what would need to be done for you to accept a PR that adds VALARM functionality?

hoodie commented 2 years ago

It requires some internal changes I think, since event/todo components need to be able to have associated children. I have parts of the work already done on a local branch and will give it more time this weekend.

beyarkay commented 2 years ago

Okay thanks. This would be an extremely helpful feature so let me know if you'd like me to take charge and implement it, or otherwise how I can help out

hoodie commented 1 year ago

I suppose the weekend was longer than intended

hoodie commented 1 year ago

just released 0.14.0. closing this, if you'd like to talk about changes, please open a new issue. Thanks for every bodies input and support.

beyarkay commented 1 year ago

Thank you so much!

mre commented 1 year ago

We already started to use this feature in zerocal: https://github.com/mre/zerocal/pull/24