search

hoodie / icalendar-rs

📆 icalendar library, in Rust of course - for fun
Apache License 2.0
126 stars 34 forks source link

Use AsRef<str> for find_prop #52

Closed WhyNotHugo closed 2 years ago

WhyNotHugo commented 2 years ago

This allows passing things like String or CStr and alike. Usually, it's good practice to use AsRef instad of &str for fuction parameters.

See: http://xion.io/post/code/rust-string-args.html

WhyNotHugo commented 2 years ago

Mostly handy since I have a few situations where I need to compare to String.

hoodie commented 2 years ago

nice, thank you

hoodie commented 2 years ago

waa, sorry, wrong button, meant to merge, not close 🙈

hoodie commented 2 years ago

so I hope I can make that up by just releasing this immediately ;) thanks for the contribution