hoodie / icalendar-rs

📆 icalendar library, in Rust of course - for fun
Apache License 2.0
122 stars 32 forks source link

fix: support for multi-properties #82

Closed daveterra closed 10 months ago

daveterra commented 10 months ago

WIP: Add support for multi-properties in calendar parsing.

daveterra commented 10 months ago

Here is the basic outline, let me know what needs to change or any other feedback. I'm still pretty new to Rust so I've very likely missed something, especially around lifetimes.

hoodie commented 10 months ago

@daveterra I'll take this over if you don't mind

daveterra commented 10 months ago

@daveterra I'll take this over if you don't mind

Sounds good! Let me know if there is anything else I can help with.

hoodie commented 10 months ago

thank you so much for finding this and helping out with the fix!!!

hoodie commented 10 months ago

https://crates.io/crates/icalendar/0.15.9

qwandor commented 10 months ago

This should be a semver-breaking change, as it changes the signature of the public Component::multi_properties method.

hoodie commented 10 months ago

Oh no you're right. I had run semver checks but it didn't report that. I'll have that version.

hoodie commented 10 months ago

@qwandor thanks for ringing the alarm, it's 16.0.0 now 👏

qwandor commented 10 months ago

I assume you mean 0.16.0? Thanks!

hoodie commented 10 months ago

of course