Open matthiasbeyer opened 1 month ago
Thanks for letting me know, I was a bit confused how this was possible until I looked at the combination of things.
The feature flag for using zbus is "z"
not "zbus"
. I think I could technically just change that. Or document that better. Not sure. Any suggestion?
Well for me it was unclear that z
is the feature flag I need. You could add a compiler error if a user only enables zbus
but not serde
, but I am not sure whether this is actually an error... can the crate work without serde
when `zbus is used? If not, why have it as seperate features?
https://github.com/hoodie/notify-rust/blob/c253a82f53c24ad29d4aeecec84952e53a886d52/src/xdg/zbus_rs.rs#L217
This line makes the compiler unhappy if I use
notify-rust
withdefault-features = false, features = ["zbus"]
.You may want to check the feature gates on this particular code piece :wink:
Full error: