hoodie / notify-rust

☝️send desktop notifications from your Rust app.
Apache License 2.0
1.17k stars 74 forks source link

Consider disabling default features on `image` crate #225

Open nazar-pc opened 3 months ago

nazar-pc commented 3 months ago

When images feature is enabled and image dependency is brought in, it pulls in a bunch of other dependencies to support various image formats, though according to quick search they are not used in this crate, so using default-features = false would allow to remove a lot of unnecessary indirect dependencies.

UPD: Yes, there is Image::open(), but for those who decode images themselves it should not be required to pull all of the dependencies and if that is in fact needed, additional feature can be used just for that.

hoodie commented 3 months ago

That is a great point. Thanks.