Guidance Requested - Githubissues

hoodie / toastify

🍞A commandline tool that shows desktop notifications using notify-rust

Apache License 2.0

94 stars 8 forks source link

Guidance Requested #10

Closed hybras closed 3 years ago

hybras commented 3 years ago

I'm basically rewriting toastify.

[x] Upgrade Deps (clap, notify)
[x] Use clap derive
[x] properly scope features (info and server don't exist on macOS, rather than failing
[x] Rework cli (title/summary and body as --named not positional args)
[ ] docs

I'd appreciate testing in linux and windows, I have a mac. I will rebase before marking this ready, to rename / rearrange / split / combine commits.

hoodie commented 3 years ago

Thank you so much for this already. I would like to give you good feedback, but I'm a bit swamped ATM. I'll try to get back to you some time this week. Thanks so much for putting in the time already.

hybras commented 3 years ago

I am unable to test. I am confused because the binary I installed with cargo works fine.

Debugging my build shows that it also works fine. I can see that it calls the notification method and step into the macOS API. No errors are displayed.

Running a debug build from your master branch also does not work, and I can confirm with debugging that it calls the notification method as well.