hoodie / toastify

🍞A commandline tool that shows desktop notifications using notify-rust
Apache License 2.0
94 stars 8 forks source link

Please publish Cargo.lock with the crate #3

Closed polyzen closed 5 years ago

polyzen commented 5 years ago
    Updating crates.io index
    Updating git repository `https://github.com/hoodie/notify-rust/`
error: the lock file needs to be updated but --locked was passed to prevent this
hoodie commented 5 years ago

sure thing, how about now?

polyzen commented 5 years ago

Thank you very much. :)

I see this is now also available as a crate. Could you try this to publish the lock file with the crate?: https://github.com/rust-lang/cargo/issues/5654

hoodie commented 5 years ago

That's not the default? I thought it published all checked in files automatically, I'll look

polyzen commented 5 years ago

https://github.com/rust-lang/cargo/blob/0.31.0/src/cargo/sources/path.rs#L346-L349

Edit: Please also tag the 0.3.4 release. :)

polyzen commented 5 years ago

I've learned unstable Cargo features require Cargo nightly. Will bump this once it's stabilized.

hoodie commented 5 years ago

@polyzen ping

polyzen commented 5 years ago

Cargo will be changed to always include Cargo.lock in the .crate file if the package has binaries or examples.