hoodie / toastify

🍞A commandline tool that shows desktop notifications using notify-rust
Apache License 2.0
94 stars 8 forks source link

Using notification id as optinal parameter #6

Closed tfachmann closed 5 years ago

tfachmann commented 5 years ago

having a notification that updates like a volume indicator the possibility to overwrite existing notifications is crucial.

notify_rust already implements this functionality with an id.

This functionality is provided by dunstify. However, notify-send and toastify lack of this feature so far, even tho it is trivial to implement.

hoodie commented 5 years ago

I had not considered that meaningful since you would need to get the original ID of that notification you'd want to update - but it appears you can just make one up from the start. feels a bit weird, but ok, the spec isn't completely clear here

what desktops have you tried this out on?

hoodie commented 5 years ago

also, you can go ahead and remove rust 1.0.0 from the .travis.yml this is what keeps travis from giving you full thumbs up

hoodie commented 5 years ago

actually, don't change the travis file, I just cleaned that up myself :D

tfachmann commented 5 years ago

I had not considered that meaningful since you would need to get the original ID of that notification you'd want to update - but it appears you can just make one up from the start. feels a bit weird, but ok, the spec isn't completely clear here

what desktops have you tried this out on?

I am using i3 and haven't been testing it on other desktops. The Arch wiki suggests the functionality of using the Notification-ID aswell, which was so far only implemented by dunstify

tfachmann commented 5 years ago

Sorry for the mess, hope it's alright now.. haven't been squashing commits so far. Alternatively I could rebase aswell

hoodie commented 5 years ago

just do git fetch && git rebase -i origin/master and change pick to fixup everywhere but commit named "implemented notification id as optional paramter"

hoodie commented 5 years ago

thank you! now go to bed :grin: