search

hoodiehq-archive / hoodie-electron-app

https://rookies-rgsoc2016.github.io/hoodie-electron-app/
Apache License 2.0
5 stars 1 forks source link

Check char in update #67

Closed flyjwayur closed 8 years ago

flyjwayur commented 8 years ago

@gr2m @titay2 Hey, I'm working on checking letters in edit-app-container. It checks letters of the new app name and pretty similar with checking letters in create-app-container.tag. But I have one error now. When I clicked 'apply' button for updating new name to app, in console it shows this error. as below (The original app name was 'a' and I gave app name 'a2' to app for testing.) It seems like it's not taking a new app name in the route. 

index.html#/apps/a/edit:1
Uncaught (in promise) Apps.update() is not yet implemented

Can using global variable(var renameInput = self["app-new-name"].value) for 'handleRenameInput' and 'handleSubmit' functions ?:)

gr2m commented 8 years ago

@flyjwayur I’ve updated your pull request because it included all the dist/ files, I had to git push --force it, so make sure to do git pull before you continue working on it.

gr2m commented 8 years ago

actually there are a lot of changes that revert things that we added recently, let me fix it

gr2m commented 8 years ago

okay never mind, I’m sorry but you’ll have to restart this pull request. Make sure you have the latest commit of the master branch before you create your branch, because the one you started with was definitely out of date