search

hoodiehq-archive / hoodie-plugin-template

⛔ deprecated
4 stars 4 forks source link

make assertion errors not fatal errors #4

Open janl opened 10 years ago

janl commented 10 years ago

with the setup up tear down of a full hoodie instance for hook and browser tests, it’s not very fun to have things bail on assertion errors, as the whole tear down phase is skipped and one has to kill hoodie manually afterwards. I couldn’t easily find out where this is configured.

svnlto commented 10 years ago

I'd say that's expected behaviour of any testing framework, to bail on error.

janl commented 10 years ago

Bail to the point of where test setup is left dangling, I'd strongly disagree with.

The things I usually work with run all tests and report the errors at the end with an option to do a full halt of you want to inspect things for debugging. I'd expect this to work the same way.

We certainly can't have plugin authors chase node and couch pids to kill them manually while trying to write tests.

On 29.03.2014, at 14:31, Sven Lito notifications@github.com wrote

I'd say that's expected behaviour of any testing framework, to bail on error.

— Reply to this email directly or view it on GitHub.

svnlto commented 10 years ago

Yeah I get that and I agree, but what I'm saying is - my understanding is that's down to the test framework to provide a hook or something, right?

I believe we have a stop task on the grunt-hoodie plugin that forces a "cleanup"

janl commented 10 years ago

Yeah, I am not saying we should invent anything, I'm just saying the current situation is broken and I don't know how any of this works, so I am filing a bug for the authors :)

On 29.03.2014, at 15:15, Sven Lito notifications@github.com wrote:

Yeah I get that and I agree, but what I'm saying is - my understanding is that's down to the test framework to provide a hook or something, right?

I believe we have a stop task on the grunt-hoodie plugin that forces a "cleanup"

— Reply to this email directly or view it on GitHub.