hoodiehq-archive / my-first-hoodie

⛔ deprecated
Other
157 stars 35 forks source link

ARIA roles & HTML semantics for a more accessible experience #75

Closed varjmes closed 9 years ago

varjmes commented 9 years ago

Hello! I am here to deliver some lovely accessibility to my-first-hoodie!

I've done a series of small commits, so if anyone doesn't agree with one of them I can take it out easily :)

There are a couple of more complex things I'd like to do in future PRs like letting the user know that they have successfully submitted/finished/deleted their todo, perhaps with use of ARIA live regions.

varjmes commented 9 years ago

I hope I got the commit messages right, @gr2m :dancer:

gr2m commented 9 years ago

you're a commit super :star2:

gr2m commented 9 years ago

you just won the price for the best explained PR in Hoodie History :tada:

Looks all good to me :+1:

gr2m commented 9 years ago

merged via d337367

boennemann commented 9 years ago

@Charlotteis Thanks for all of this :tada:

Your explanations are so good that we should ingrain them into the history of this project :) I don't know what you're using for git, but let's suppose it's the command line:

Instead of doing git commit -m "the message" you can just do git commit, which then opens your editor of choice, which again makes it easy to enter the summaries you're using now as the first line and the entire explanation right below that as the commit message body. Here is an example of what that looks like.

Thanks :sparkling_heart:

varjmes commented 9 years ago

@boennemann Thanks!

I do actually use Gitx sometimes if I want to do longer commit messages (it's also just a great GUI for git), though primarily I use the command line. I try not to write messages that are too long because I know some people frown upon them. I will endeavour to do longer explanations where needed, particularly for accessibility stuff! :tada: