hoodiehq-archive / my-first-hoodie

⛔ deprecated
Other
157 stars 35 forks source link

Establish a merge/release protocol for this repo #78

Open espy opened 9 years ago

espy commented 9 years ago

MFH is the first thing new Hoodie users will see, and we have to be absolutely certain it works correctly. For this reason we'd like to implement two procedures here:

  1. PRs in this repo must be reviewed by two people
  2. This repo needs a merge/release checklist that any committer should work through before submitting a PR (covering testing, dependencies, etc.)
varjmes commented 9 years ago

This is a great idea. I have seen repositories that have an awesome merge checklist that is added to any new PR that is created, automatically. I am trying to see if I can get access to the core code, so perhaps we can get it added here. If not, perhaps this is something that someone would like to build themselves?

The process is:

gr2m commented 9 years ago

sounds great!

varjmes commented 9 years ago

This is the pull-request bot that some of us use at work. I asked and am told we are free to fork it/use it whatever. Perhaps this is something that hoodie-bot could do for us.

Here is the repo: https://github.com/ms-digital-labs/pull-request-bot

varjmes commented 9 years ago

If we didn't want to use that one, this is also a thing: https://github.com/btford/mary-poppins, with this plugin: https://github.com/btford/poppins-pr-checklist