On Firefox Nightly, enter key doesn't create a new task.

hoodiehq-archive / my-first-hoodie

⛔ deprecated

Other

157 stars 35 forks source link

On Firefox Nightly, enter key doesn't create a new task. #8

Closed davidascher closed 11 years ago

davidascher commented 11 years ago

Not sure why, not sure if it's only this version at this point.

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20130411 Firefox/23.0

frenkie commented 11 years ago

True, the code is using e.charCode to detect the key, it should be e.keyCode to get the ENTER key, see also http://stackoverflow.com/questions/1444477/keycode-and-charcode

janl commented 11 years ago

Confirmed that it does not work in Firefox 19.0.2 as well.

I added a console.log and alert to the top of the keypress callback, but don’t seem to hit that particular code path as I get no output. Leaving this one for @gr2m and @espy.

gr2m commented 11 years ago

I can look into it tomorrow, thanks for bringing it up

caolan commented 11 years ago

Confirmed on FF 20