hoodiehq-archive / my-first-hoodie

⛔ deprecated
Other
157 stars 35 forks source link

Bit of styling and rewording #86

Open espy opened 8 years ago

espy commented 8 years ago

Nicer buttons with hover and focus states, tidier text alignments, and normalize.css is now part of the repo, because I found myself working on this on the train, offline, unable to load it from github.

I also changed all instances of login, log out and register to sign in, sign out and sign up to match the Hoodie API.

Also, submit is now add item, so that corresponds with the use of item in other places.

Now looks like this:

bildschirmfoto 2016-01-01 um 13 53 03
gr2m commented 8 years ago

rebased on something-tracker branch & pit push -fd

gr2m commented 8 years ago

hmmm no idea why tests fail, I'll check it later, we can merge this as is, here’s a preview (without sign up / sign in working): https://rawgit.com/hoodiehq/my-first-hoodie/espy-styles/www/index.html

espy commented 8 years ago

Ah, I just noticed I forgot the username/password fields because I was logged in all the time. I'll do those soon.

NickColley commented 8 years ago

Looking good!

Does this make sure that the inputs at the top of the screen are using consistent styles with the rest, noticed the button at the top in the screenshot is a lot smaller than the others used.

Theres some other things odd with the inputs at the top so maybe we could address them separately and not block this.

espy commented 8 years ago

@nickcolley I forgot the ones at the top because I was logged in all the time, and they're not visible then. I'll fix that soonish, along with a few other details concerning responsiveness.

NickColley commented 8 years ago

Just making a PR for your PR, PR.

gr2m commented 8 years ago

I’ve created https://github.com/hoodiehq/hoodie-app-something-tracker now, can you start the PR again for that repo? I didn’t touch assets much, only added password reset button