search

hoodiehq-archive / node-multicouch

Launch multiple CouchDBs from the same installation.
30 stars 18 forks source link

Cleanup #17

Closed svnlto closed 10 years ago

janl commented 10 years ago

LGTM. Haven’t run the code myself. If it works, let’s get this merged :)

svnlto commented 10 years ago

I suggest we add some basic tests.

janl commented 10 years ago

I like the ideas of tests, but I don’t know how to test things here since all this module does is work around platform specific differences.

svnlto commented 10 years ago

well, we should mock those and switch around environments and then see of the mocks are getting passed through to the other end successfully if that makes sense?

janl commented 10 years ago

maybe we can factor out the code that does the detection of the differences and test that with different inputs, that could work.

janl commented 10 years ago

ah yes, what you said!

svnlto commented 10 years ago

maybe we can factor out the code that does the detection of the differences and test that with different inputs, that could work.

yup.

janl commented 10 years ago

sounds like a plan!

svnlto commented 10 years ago

please don't merge this. things aren't working right now.