search

hoodiehq / camp

:circus_tent: Welcome to Hoodie Camp!
https://hoodie.camp
Apache License 2.0
99 stars 55 forks source link

💯 Code Coverage for Hoodie Account Server #53

Closed LowProfileDog closed 7 years ago

LowProfileDog commented 7 years ago

This is a starter issue.

:octocat: Your First Pull Request?

We would like to take the opportunity to invite someone who did not yet contribute to Hoodie to work on this issue. Follow @YourFirstPR on Twitter for more of these issues across many open source projects :)

🤔 What you will need to know

JavaScript, Node.js. Knowledge about npm would be helpful but are not required, you’ll figure it out as you go :)

:dart: The goal

100% code coverage makes sure that every single line of code is covered by tests. And it looks pretty cool once we have all the 💯 for all modules in Hoodie’s Architecture

The current status is Coverage Status

hoodie-account-server-coverage

:clipboard: Step by Step

Coordinate with #52 as we need to write a test for plugin/index.js, to avoid duplicated work :)

🤔❓ Questions

Ping us in the Hoodie Chat or on Twitter

evgimov commented 7 years ago

Can I do it?

On Oct 4, 2016 8:21 PM, "Low-Profile Dog" notifications@github.com wrote:

This is a starter issue http://hood.ie/blog/starter-issues.html. It’s reserved for participants of OSCON Contribute https://ti.to/hoodie/oscon-meet-the-hoodies until May 20th, 2016. [image: :octocat:] Your First Pull Request?

We would like to take the opportunity to invite someone who did not yet contribute to Hoodie to work on this issue. Follow @YourFirstPR https://twitter.com/yourfirstPR on Twitter for more of these issues across many open source projects :) 🤔 What you will need to know

JavaScript, Node.js. Knowledge about npm https://docs.npmjs.com/ would be helpful but are not required, you’ll figure it out as you go :) 🎯 The goal

100% code coverage makes sure that every single line of code is covered by tests. And it looks pretty cool once we have all the 💯 for all modules in Hoodie’s Architecture https://github.com/hoodiehq/hoodie/tree/master/server#architecture

The current status is [image: Coverage Status] https://coveralls.io/r/hoodiehq/hoodie?branch=master [image: hoodie-account-server-coverage] https://cloud.githubusercontent.com/assets/17463029/19099009/15d51026-8a67-11e6-9caf-acc31ab51e6d.png 📋 Step by Step

  • 🙋 Claim this issue: Comment below (or assign yourself and continue at step 4 :) Please 🙏 only claim if you want to start working on it within a day. Once claimed we add you as contributor to this repository.
  • 👌 Accept our invitation to this repository. Once accepted, assign yourself to this repository
  • 👓 Please review our Code of Conduct http://hood.ie/code-of-conduct/ In a nutshell: be patient and actively kind with us 😊
  • 🔄 replace the up for grabs label with in progress.
  • Setup the repository locally https://github.com/hoodiehq/hoodie-account-server/tree/master/tests Ensure the tests pass
  • Bring coverage to 100%. Use the following steps
  • 🔀 Start a Pull Request. Mention closes hoodiehq/camp#THISISSUE NUMBER in the description. If this is your first, welcome 🎉 😄 Here is a great tutorial https://egghead.io/series/how-to-contribute-to-an-open-source-project-on-github on how to send a pull request using the terminal.
  • 🏁 Done 👍 Replace the in progress label with ready. Ask in comments for a review :)

Coordinate with #52 https://github.com/hoodiehq/camp/issues/52 as we need to write a test for plugin/index.js, to avoid duplicated work :) 🤔❓ Questions

Ping us in the Hoodie Chat http://hood.ie/chat/ or on Twitter https://twitter.com/hoodiehq/

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/hoodiehq/camp/issues/53, or mute the thread https://github.com/notifications/unsubscribe-auth/AKD_5ZboLeJMgBF5gIaQTJSqclLUIoS3ks5qwxfGgaJpZM4KOYcA .

gr2m commented 7 years ago

Hey Evghenii, this is quite a complex task, have you worked with automated testing and code coverage before? It’s not a good task to learn these things. Maybe try to go trough these steps and increase the code coverage and see if you feel comfortable doing it?

evgimov commented 7 years ago

I haven't worked with automated testing. Yes, I will try. Maybe do you have another task for me?

2016-10-04 20:38 GMT-07:00 Gregor Martynus notifications@github.com:

Hey Evghenii, this is quite a complex task, have you worked with automated testing and code coverage before? It’s not a good task to learn these things,. Maybe try to go trough these steps and to increase the code coverage and see if you feel comfortable doing it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hoodiehq/camp/issues/53#issuecomment-251574204, or mute the thread https://github.com/notifications/unsubscribe-auth/AKD_5RJcsY3FrqD61fa7XKLQeX2lnsheks5qwxu3gaJpZM4KOYcA .

gr2m commented 7 years ago

Not right now, I’m sorry! But you can watch this repository to be notified of new issues. Great resources are http://www.firsttimersonly.com/ and http://yourfirstpr.github.io/, and look for issues with the hacktoberfest label. Good luck!

evgimov commented 7 years ago

Thank you, have a good day!

2016-10-04 23:17 GMT-07:00 Gregor Martynus notifications@github.com:

Not right now, I’m sorry! But you can watch this repository to be notified of new issues. Great resources are http://www.firsttimersonly.com/ and http://yourfirstpr.github.io/, and look for issues with the hacktoberfest label https://github.com/search?utf8=%E2%9C%93&q=label%3Ahacktoberfest+is%3Aissue+is%3Aopen&type=Issues&ref=searchresults. Good luck!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/hoodiehq/camp/issues/53#issuecomment-251591254, or mute the thread https://github.com/notifications/unsubscribe-auth/AKD_5f-zUNlugCPSrx3xfQTz4y_0BZoLks5qw0D_gaJpZM4KOYcA .

guntbert commented 7 years ago

Hi, there seems to be a typo: "reserved until May 2016"?

gr2m commented 7 years ago

@guntbert thanks, removed it :)

karanjthakkar commented 7 years ago

@gr2m I'd like to pick this up if its still unclaimed :)

nachiketdhamankar commented 7 years ago

I'd like to give it a try if its open. It would be nice to try it as a first timer :)

varjmes commented 7 years ago

This appears to be unclaimed and @karanjthakkar came first. So, good luck Karan!

varjmes commented 7 years ago

@karanjthakkar I gave you write access to this repo so you can assign yourself :)

karanjthakkar commented 7 years ago

Thanks @Charlotteis! I'll send a PR in some time :)

karanjthakkar commented 7 years ago

I just realised that I'll be on vacation until mid next week, so someone else can pick this issue :)

nachiketdhamankar commented 7 years ago

yay! I get to try it now right? :)

gr2m commented 7 years ago

@nachiketdhamankar do you know Node.js, testing, code coverage? It’s not a good issue for beginners, I just want to be sure you know what you commit to :)

guiferpa commented 7 years ago

Can I do it? 🛩

gr2m commented 7 years ago

do you two want to work on it together? @gpaixao you seem more experienced, would you be okay with taking some extra time and explaining how you will approach it first and why, and then do the implementation? I’ll be here of course to help answer questions as well.

@nachiketdhamankar would that work for you?

nachiketdhamankar commented 7 years ago

@gr2m That would be really nice :D

guiferpa commented 7 years ago

@gr2m ok, good idea.

I've a question... The coverage in all modules of hoodiehq ? I'm reading here and don't know right where will do the coverage.

One more question :smiley: ... How will do the dynamics between me and @nachiketdhamankar

Ps: I want catch this issue

gr2m commented 7 years ago

@gpaixao the coverage is just for this repository: https://github.com/hoodiehq/hoodie-account-server. You can set it up and then run 

./node_modules/.bin/nyc report --reporter=lcov

This will create / update the coverage folder in the repository (it is ignored by git). Now open open coverage/lcov-report/index.html in your browser to see which lines are not yet covered by tests, then write tests until they are all covered

guiferpa commented 7 years ago

@gr2m tks. How do i get this issue for me? I've that set something?

gr2m commented 7 years ago

@gpaixao I’ve invited you to this repo, you can accept the invitation at https://github.com/hoodiehq/camp/invitations. Once accepted, you can assign yourself and start checking off the checkboxes above

guiferpa commented 7 years ago

@gr2m I'm studying the project, I like the issue 😆

nachiketdhamankar commented 7 years ago

@gr2m Can you add me too? I can just follow @gpaixao and try to understand if thats ok? :)

guiferpa commented 7 years ago

Don't need @nachiketdhamankar, I go create tests. Only write about that to doing!

gr2m commented 7 years ago

@nachiketdhamankar I’ve invited you to the repository, you can co-assign yourself once you accepted the invitation at https://github.com/hoodiehq/camp/invitations.

Good luck you two :)

nachiketdhamankar commented 7 years ago

@gpaixao I'm sorry I didn't get you ☺️

nachiketdhamankar commented 7 years ago

@gpaixao Is there any way I can contact you? :)

guiferpa commented 7 years ago

@nachiketdhamankar yes, my e-mail: guilhermee.paixaoo@gmail.com .

gr2m commented 7 years ago

@gpaixao did you mean to close this issue? Current coverage is at 93%, still work to be done :)

guiferpa commented 7 years ago

Sorry sorry, I'm confounds. Sorry again. :/

gr2m commented 7 years ago

no problem :)

gr2m commented 7 years ago

hey @gpaixao @nachiketdhamankar are you still looking into this issue?

guiferpa commented 7 years ago

I have a problem in my work. I am out of time. :worried:

gr2m commented 7 years ago

no worries at all, all the best for your work 👍

Anyone else want to give this a try?

danieltotherescue commented 7 years ago

Desireedesario and I (danieltotherescue) would like to work on this.

LowProfileDog commented 7 years ago

The issue is all yours :) I’ve invited you both to our Camp repository, you can accept my invitation at https://github.com/hoodiehq/camp/invitations

Once accepted, you can assign yourself to this issue and check off the checkboxes above. Enjoy 🐕

gr2m commented 7 years ago

try this for debugging coverage:

./node_modules/.bin/nyc report --reporter lcov

And then open coverage/lcov-report/index.html in your browser of choice

gr2m commented 7 years ago

all done via https://github.com/hoodiehq/hoodie-account-server/issues/226 thanks everyone!