[hoodie-account-server] GET /accounts Add test for 401 "Session invalid"

🎃💻👕 Hacktoberfest: Trick or Treat!

If you haven’t yet, sign up for Hacktoberfest to earn an exclusive T-Shirt. Plus I’m sure we can teach you a cool trick or two in the process

🤔 What you will need to know

You should have worked with JavaScript, Node.js and Testing. This is a rather advanced issue, you will need to write tests yourself and then resolve the issue. If you haven’t done that before, better look for another issue :)

Some knowledge about Hapi will help but you can figure it out if you know the things above :)

🐞 The Bug

Requests like GET /accounts require a valid session. The server validates the session by parsing the authorization request header.

As defined in the Account JSON API Spec, the server should respond with 401 Unauthorized – Authorization header missing instead of 403.

:dart: The goal

As defined in the Account JSON API Spec, the server should respond with 401 Unauthorized – Session invalid. It probably does that already but we can’t be sure unless we have a test for it :)

:clipboard: Step by Step

If this is your first, welcome :tada: :smile: Here is a great tutorial on how to send a pull request using the terminal.

[x] 🙋 Claim this issue: @simonyangme (Note: Fullstack LA Hacktoberfest Edition attendees only) Comment below (or assign yourself and continue at step 4 :)
Please 🙏 only claim if you want to start working on it during the event.
Once claimed we add you as contributor to this repository.
[x] 👌 Accept our invitation to this repository. Once accepted, assign yourself to this repository
[x] 👓 Please review our Code of Conduct
In a nutshell: be patient and actively kind with us 😊
[x] 🏷 add the label in progress.
[x] 🗜 Setup the repository locally
[x] Create the test in tests/integration/routes/accounts/get-accounts-test.js
[x] Commit the change with test(routes): GET /accounts with invalid session and push it either to your fork or push your new branch. Your tests should fail now
[x] 🔀 Start a Pull Request. Mention closes hoodiehq/camp#62 in the description.
[x] If the test passes, all good 👍 If the server does not respond as expected, figure out why and fix it 👍
[x] 🏁 Done :+1: Replace the in progress label with ready. Ask in comments for a review :)
🤔❓ Questions

Ping us in the Hoodie Chat or on Twitter

hoodiehq / camp