hoodiehq / discussion

General discussions and questions about Hoodie
7 stars 1 forks source link

[next] rename /hoodie/bundle.js route to /hoodie/client.js #89

Closed gr2m closed 8 years ago

gr2m commented 8 years ago

We talk about about "Hoodie client" and it will be mentioned a lot in the documentation, also the main repository is hoodie-client. So it would be more consistent to have the route where the Hoodie client is served /hoodie/client.js.

Note that /hoodie/client.js is not serving hoodie-client 1:1. hoodie-client returns a Hoodie constructor, /hoodie/client.js returns an instance of Hoodie with options passed in.

Any thoughts?

@boennemann @christophwitzko @janl

varjmes commented 8 years ago

Sounds good to me, it make sense even if it's not a 1:1.

HipsterBrown commented 8 years ago

Makes sense to keep it in sync with the current documentation, especially since "bundle" sounds a lot more related to Browserify than Hoodie. 1:1 FTW. :+1:

boennemann commented 8 years ago

We talk about about "Hoodie client" and it will be mentioned a lot in the documentation, also the main repository is hoodie-client. So it would be more consistent to have the route where the Hoodie client is served /hoodie/client.js.

+1

Note that /hoodie/client.js is not serving hoodie-client 1:1. hoodie-client returns a Hoodie constructor, /hoodie/client.js returns an instance of Hoodie with options passed in.

Currently it is the pre-built hoodie-client though.

gr2m commented 8 years ago

it’s decided then, let’s do it: https://github.com/hoodiehq/hoodie-server/issues/459