Open brunopedroso opened 8 years ago
I think this was resolved via https://github.com/hoodiehq/hoodie/pull/600, released in https://github.com/hoodiehq/hoodie/releases/tag/v24.2.1, can you check please?
Actually, that does not solve the problem. I'm already on hoodie 24.2.2...
It looks like these lines do not use getHapiOptions()...
you are right! Hmm ... We kinda have a lot of code duplication here. I wonder if we should use some internal code here from the hoodie
package, like the getHapiOptions
method, like so
var getHapiOptions = require('hoodie/cli/hapi-options')
it’s usually bad practice, but still better than duplicating the code and risking it gets out of sync like it did now.
Another option is to remove the server component entirely from ember-hoodie
and document how to set it up yourself, to make it more explicit ...
What do you think?
I must say I feel, as an app dev, it's very inviting to install an ember addon, type ember s
and already have hoodie ready for development! I wont remove this...
Maybe the hoodie module could expose a configured hapi server instance?
it's very inviting to install an ember addon, type ember s and already have hoodie ready for development!
Yeah I agree
Maybe the hoodie module could expose a configured hapi server instance?
I’m not sure what you mean by that? We can either use hoodie which comes with the whole package, or we use @hoodie/server which only has the backend components for store & account
I mean, if ember-hoodie
must require an internal file inside hoodie
module, then I think it would be more meaningful to me to import a configured instance than to import a getHapiOptions
method... something similar to what is done here when it imports the whole run function.
just an idea, btw...
actually, the run function does configre other things... not just the connection
options, but also a a server
options and who know what else eventually...
I'm running this example app and, at the moment I submit the login request the process is running
ember s
stops with the following error:I researched a little and found out that this error is thrown by this assert.
I changed these lines to include
routes: { log: true }
just like someone proposed here, and the error stopped.