search

hoodiehq / faq

Frequently asked questions about Hoodie
faq.hood.ie
11 stars 3 forks source link

fix(html semantics/a11y): add nav blocks with aria roles #105

Closed varjmes closed 9 years ago

varjmes commented 9 years ago

This PR does two things:

  1. Surrounds all navigation lists with a <nav> block.
  2. Adds an ARIA role of navigation to each navigation block.

You cannot add a role of navigation to a <ul> so we must put the <ul> within a <nav> block, which is also good to for HTML semantics/purity. You can have multiple <nav>'s on a page, so this shouldn't be a problem. I also don't see any indication of special CSS styling on the nav so this shouldn't bring about any visual changes.

gr2m commented 9 years ago

looks good to me :+1:

boennemann commented 9 years ago

Thank you @Charlotteis!

These changes visually break the navigation as the Hamburger moves to left, right next to the Hoodie logo. Also, unrelated to this change but still, the Hamburger is entirely ignored by VoiceOver.

How can we best fix this? This change would also apply to hood.ie in general, right? @espy @verpixelt

boennemann commented 9 years ago

related: https://github.com/hoodiehq/faq/issues/100

varjmes commented 9 years ago

Closing this PR in favour of putting more thought into our navigation. I will write this on a list of things we could improve for the main site and we can merge those changes into faqs afterwards :)