search

hoodiehq / hood.ie

:dog: Hoodie Website
http://hood.ie
Apache License 2.0
78 stars 61 forks source link

test for insensitive wording using alex.js #333

Closed tsriram closed 7 years ago

tsriram commented 7 years ago

npm script to test for insensitive wording using alex.js

Script currently takes a directory or a file (or both) as input and prints the messages from alex.js in console.

Usage:

npm run alex -- -d _posts or npm run alex --f _posts/my_new_post.md

Should the script take _posts as the default directory and test for insensitive wording in all files there if no input is given? (have left the code for this; will include or delete post confirmation)

is the naming (alex.js) and keeping it in repository root okay?

Please suggest any changes if required. This should close #194

tsriram commented 7 years ago

@gr2m @Charlotteis did you get a chance to check this?

gr2m commented 7 years ago

I still have it on my list, I’m sorry for the delay. I’ll have a look now

varjmes commented 7 years ago

A lot of instances of no spaces between if and parentheses. Spaces between '}' and catch/try etc would be good too.

gr2m commented 7 years ago

Lookgs goo to me now, ping @Charlotteis

varjmes commented 7 years ago

LGTM!

gr2m commented 7 years ago

w00p, thanks @tsriram & @Charlotteis 👏

tsriram commented 7 years ago

Thanks a lot @gr2m & @Charlotteis, it was a nice experience to work with you on this. A lot of learning!