Closed igotpassion closed 7 years ago
@skeskali and @gr2m - I'm hoping I submitted changes using the correct workflow. Apologies if I did not. Let me know if you need anything else on my end for this.
I’m curious why there’s not a single pull quote from any of the listed reads, since that’s been a mainstay of the feature since the beginning.
Also what’s the significance in this format change as well, where the name of the site appears in parenthesis but isn’t linked?
@renrutnnej Good point on the pull quotes. I'll include some. I also decided to add sources in parentheses simply so people know what the source is. Some people might appreciate that. However only an A/B test could tell. (Maybe something we can do later.) I don't mind removing them for now if you think they are superfluous.
Looks like we'll have to push back another week. I'll submit another PR with updates based on Jenn's comments and some updated links.
I like the addition of the sources for links. I also like pull quotes, but sometimes I felt they made TGIF a little too long. They were also the feature that made compiling TGIF the most time consuming, as you have to read every article to find the best pull quotes.
On Nov 4, 2016, at 1:04 PM, Robert Gibb notifications@github.com wrote:
@renrutnnej https://github.com/renrutnnej Good point on the pull quotes. I'll include some. I also decided to add sources in parentheses simply so people know what the source is. Some people might appreciate that. However only an A/B test could tell. (Maybe something we can do later.) I don't mind removing them for now if you think they are superfluous.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/hoodiehq/hood.ie/pull/340#issuecomment-258533879, or mute the thread https://github.com/notifications/unsubscribe-auth/ACoIfKMfPxhwV5-RfO3SeSycDAdDp9Yqks5q64_RgaJpZM4KpoSB.
Thanks for your input Cecily! I'm going to include the sources this time around but do want to A/B test it in the future. I'm very interested if the inclusion of them has any impact on clickthroughs. As for the pull quotes, they do add a nice touch. I'll go ahead and add two of them.
@renrutnnej Also, just noticed that you weren't questioning the inclusion of the source necessarily but why it's not linked. I'll go ahead and link it as well. With 102 I wanted to test some different things out but don't want to interfere with the styleguide because it's solid.
Made changes. Let me know if y'all have any final suggestions or revisions. Thanks!
Merged.
Is someone able to publish this today?
I’m on it
great job @igotpassion <3
Thanks everyone!
Updates were made based on comments from @machikoyasuda and @renrutnnej. Thank you my friends!