search

hoodiehq / hoodie-account-client

:dog: Account client API for the browser
https://hoodiehq.github.io/hoodie-account-client
Apache License 2.0
11 stars 24 forks source link

rename bearer to session #100

Closed gr2m closed 8 years ago

gr2m commented 8 years ago

part of hoodiehq/hoodie#490

HipsterBrown commented 8 years ago

LGTM :+1:

jameswestnz commented 8 years ago

For consistency with other authorization prefixes (Bearer, Basic, etc, etc), should we be uppercasing the first "s" on session? I think it's minor, but was just curious..

Would be the same here if so: https://github.com/hoodiehq/hoodie-account-server/pull/161

gr2m commented 8 years ago

For consistency with other authorization prefixes (Bearer, Basic, etc, etc), should we be uppercasing the first "s" on session?

That’s a good point, yeah, I think we should do that, I’ll update the PRs. Does it otherwise look good for you? Thanks for reviewing!

jameswestnz commented 8 years ago

Other than the possibility of uppercasing the s in session, LGTM 👍

varjmes commented 8 years ago

LGTM once session is changed to Session

gr2m commented 8 years ago

Thanks for the reviews team!