search

hoodiehq / hoodie-account-client

:dog: Account client API for the browser
https://hoodiehq.github.io/hoodie-account-client
Apache License 2.0
11 stars 24 forks source link

getState does not set a fallback url #61

Closed Realtin closed 8 years ago

Realtin commented 8 years ago

When reproducing the Error from #54 a GET Request to http://127.0.0.1:8080/undefined/session/account is send.

setting an empty String as a fallback in utils/get-state.js should fix that.

gr2m commented 8 years ago

it’s using state.baseUrl in fetch.js and profile-fetch.js, but we never set that. It should use state.url instead

gr2m commented 8 years ago

@Realtin do you want to fix it? If not I can make a stater issue for others out of this :)

Realtin commented 8 years ago

I started with this but since I'm a bit busy right now you can just make it a starter issue and if nobody wants it then I'll try again :)

gr2m commented 8 years ago

perfect :+1:

toh82 commented 8 years ago

closing in favor of #64