search

hoodiehq / hoodie-account-client

:dog: Account client API for the browser
https://hoodiehq.github.io/hoodie-account-client
Apache License 2.0
11 stars 24 forks source link

WIP: #54 hoodie.account.fetch(), .update(), .profile.fetch() and .profile.update() should fail with UnauthenticatedError if session is invalid, but currently fails with "Not FoundError" #62

Closed Realtin closed 8 years ago

Realtin commented 8 years ago

closes #54

gr2m commented 8 years ago

@Realtin is this ready for review or are you still working on it?

Realtin commented 8 years ago

I'll continue to work on it tonight at nodeschool!

Realtin commented 8 years ago

ok, looking over the code and so on. I'm not sure If I should fix it at all since it is just a side effect of using "baseURL" instead of "url" in the options. So it is kind of "erroring" correctly. what do you think?

gr2m commented 8 years ago

ah so it will be fixed by https://github.com/hoodiehq/hoodie-client-account/issues/64?

Realtin commented 8 years ago

yes, I think so.

gr2m commented 8 years ago

done via https://github.com/hoodiehq/hoodie-client-account/pull/72