use `state.url` instead of `state.baseUrl` in fetch.js and profile-fetch.js

hoodiehq / hoodie-account-client

:dog: Account client API for the browser

https://hoodiehq.github.io/hoodie-account-client

Apache License 2.0

11 stars 24 forks source link

use `state.url` instead of `state.baseUrl` in fetch.js and profile-fetch.js #64

Closed toh82 closed 8 years ago

toh82 commented 8 years ago

Reported in: https://github.com/hoodiehq/hoodie-client-account/issues/61# When reproducing the Error from #54 a GET Request to http://127.0.0.1:8080/undefined/session/account is send.

Fix that by using state.url instead of state.baseUrl

[x] claim this issue (@Endi1)
[x] start a PR
[x] uncomment integration test test/integration/fetch-url-test.js
[x] fix state.baseUrl in fetch.js
[x] fix state.baseUrl in profile-fetch.js
[x] search for more appearance of state.baseUrl
[x] run tests and make sure that all are green
[x] review & merge
[x] check if https://github.com/hoodiehq/hoodie-client-account/pull/62 is resolved

varjmes commented 8 years ago

Ohai @toh82 thanks so much for this great issue!

Endi1 commented 8 years ago

Can I give this a try?

gr2m commented 8 years ago

@Endi1 sure. @toh82 wanted to prepare the integration test tomorrow, but if you feel confident you can go ahead :)

Endi1 commented 8 years ago

Thanks, I'll submit a PR by tomorrow :)

toh82 commented 8 years ago

Hey @Endi1 great that you took this issue, do you need any Information on this topic? If I should prepare the tests for you, let me know.

Endi1 commented 8 years ago

Hey @toh82 I'll try to write the tests too, but if I get stuck I'll be sure to ask you. Thanks!

Endi1 commented 8 years ago

@toh82 I have been slamming my head against the wall the whole afternoon and I can't seem to get this to work. Maybe if you prepare the tests then I'll have a better chance :)

gr2m commented 8 years ago

@Endi1 oh no, so sorry to hear that! Hang in there, we’ll help you get trough this :)

gr2m commented 8 years ago

@toh82 can you prepare the tests for Endi? You can send them in a separate PR, comment them out with a reference to this issue in a comment

toh82 commented 8 years ago

@gr2m @Endi1 I'm currently on #56 and my time this week is hardly limited :( sorry about that, I guess I can start to work on this tests at Friday evening.

Endi1 commented 8 years ago

@toh82 sounds good :)

gr2m commented 8 years ago

Thanks Tobias!

toh82 commented 8 years ago

Hello @Endi1 i started a the PR and added branch issue-64-use-stateurl you can see the test in the referenced PR no worries that the test currently fails, it has to since the baseUrl isn't fixed.

If you have further questions let me know.

toh82 commented 8 years ago

@Endi1 Sorry for the delay, task should now be ready, if you have questions don't hesitate asking me or @gr2m

gr2m commented 8 years ago

@Endi1 do you still want to give this a go? We are getting to a point where this becomes a blogger, if you could finish this by Monday, that’d be ace. If you have no time, no problem at all, I’m sure someone else would like to pick it up

toh82 commented 8 years ago

this will be done with pr #72