WIP use `state.url` instead of `state.baseUrl`

hoodiehq / hoodie-account-client

:dog: Account client API for the browser

https://hoodiehq.github.io/hoodie-account-client

Apache License 2.0

11 stars 24 forks source link

WIP use `state.url` instead of `state.baseUrl` #73

Closed toh82 closed 8 years ago

toh82 commented 8 years ago

helps with #64

gr2m commented 8 years ago

@toh82 I’ve adjusted your test. The integration test was mocking internal methods, but for integration tests you don’t want to do that, that’s something you do in unit tests to test the methods in isolation. I’ve also fixed the unit tests we have for account.fetch and account.profile.fetch.

Does that all make sense?

toh82 commented 8 years ago

@gr2m well, currently i have no idea about your script but it's totally fine i think, as long as it fails if "undefined" is a part of the url, I'm fine. Donno which test is better because of lack of experience in writing tests ;)