search

hoodiehq / hoodie-account-client

:dog: Account client API for the browser
https://hoodiehq.github.io/hoodie-account-client
Apache License 2.0
11 stars 24 forks source link

#66 test: 100% coverage #78

Closed acdpnk closed 8 years ago

acdpnk commented 8 years ago

WIP

gr2m commented 8 years ago

Hey @chrifpa, what’s your status here?

acdpnk commented 8 years ago

Got sick and had to stop working on it for a bit. Back now.

gr2m commented 8 years ago

Glad to hear you are good again, thanks for the update! Ping us if you have any questions :)

gr2m commented 8 years ago

Hey @chrifpa all good from your side? Any blockers right now?

acdpnk commented 8 years ago

Just a little constrained on time, sorry… :smile:

gr2m commented 8 years ago

sorry for the noisy comments by coveralls, I’ve disabled that now

gr2m commented 8 years ago

Looking great now, also getting close :)

=============================== Coverage summary ===============================
Statements   : 99.39% ( 492/495 )
Branches     : 99.28% ( 138/139 )
Functions    : 96.59% ( 85/88 )
Lines        : 99.39% ( 492/495 )
================================================================================

Let us know if you run into any blockers or have any questions, we know that some of these might be tricky to get 100% :)

acdpnk commented 8 years ago

Looks like coveralls got stuck. Anything I can do to unstick it?

finnp commented 8 years ago

@chrifpa I re-run the travis job and now it's working. 100% ftw \o/

gr2m commented 8 years ago

w00p now that looks great :clap: 

=============================== Coverage summary ===============================
Statements   : 100% ( 495/495 )
Branches     : 100% ( 137/137 )
Functions    : 100% ( 87/87 )
Lines        : 100% ( 495/495 )
================================================================================
gr2m commented 8 years ago

okay if you could fix the fixture and the typo, and clean up the commits, this is good to be merged :)

acdpnk commented 8 years ago

I think I got the commits right now 😅

Therefore ready for review @gr2m

gr2m commented 8 years ago

Yes, absolutely, perfect, wow such work, very awesome :dog: :clap:

LGTM!

ping @hoodiehq/maintainers for 2nd :eyes: review

gr2m commented 8 years ago

@chrifpa can you rebase your work on latest master? No biggie if not, the 2nd reviewer can do the rebase before merging, and then manually close this PR and the issue

acdpnk commented 8 years ago

Thanks @gr2m :)

christophwitzko commented 8 years ago

LGTM :+1: