update the admin.sessions.findAll README (if necessary) to describe how the http apifilter query string may be abstracted into the javascript api in order to to filter findAll results on the server side by username
add some integration tests in a new file matching tests/integration/admin-*.js according to the linked README.
update the implementation in admin/lib/accounts/find-all.js (if necessary) such that tests pass.
update the README again (if necessary) to reflect working state of API based on the knowledge gained during implementation
for this issue, tests need not be complete spec coverage, but while making the edits described above, it might be a good time to get more complete spec coverage in integration tests for findAll. an integration test for the filter by username usage is the bare minimum.
after these edits, make edits to the implementation of admin.sessions.add according to the TODO in admin/lib/sessions/add.js, either as part of this or a new issue.
follow up for #19 / #77
filter
query string may be abstracted into the javascript api in order to to filterfindAll
results on the server side by usernametests/integration/admin-*.js
according to the linked README.admin/lib/accounts/find-all.js
(if necessary) such that tests pass.for this issue, tests need not be complete spec coverage, but while making the edits described above, it might be a good time to get more complete spec coverage in integration tests for
findAll
. an integration test for the filter by username usage is the bare minimum.after these edits, make edits to the implementation of
admin.sessions.add
according to theTODO
inadmin/lib/sessions/add.js
, either as part of this or a new issue.